add delegation store to custom staking middleware #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterate delegation.
iterate delegation storage
|
Is this PR ready for review? If not, could you please mark it as a draft? It's how I track e'm :) thanks :)! |
absolutely. need to move it to draft. thanks. w |
…-staking override end block custom staking module implementation
…atching add logic to app module to batch delegation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…eware introduce unbondong/redelegation/cancel unbonding filed to genesis
add logic to EndBlock custom staking wrapper to dequeue all request.
Msg epoch params
RustNinja
commented
Dec 22, 2023
custom/staking/module.go
Outdated
| println("Validator Address: ", delegation.ValidatorAddress) | ||
| fmt.Println("Amount", delegation.Amount.Amount) | ||
|
|
||
| msgDelegate := stakingtypes.MsgDelegate{DelegatorAddress: delegation.DelegatorAddress, ValidatorAddress: delegation.ValidatorAddress, Amount: delegation.Amount} |
There was a problem hiding this comment.
stakingtypes.MsgDelegate could panic. and it is a problem.
Remove staking middleware storage, keepers, only params and End Block in custom staking extra logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add delegation store to custom staking middleware